Re: [PATCH v2 0/4] difftool refactoring + remove OPT_ARGUMENT() macro

From: Jeff King <peff@peff.net>
Date: Sep 13, 2021, 18:04 UTC
Message-ID: <YT+Sv6gdNTMuP5NC@coredump.intra.peff.net>
In-Reply-To: <cover-v2-0.4-00000000000-20210913T033204Z-avarab@gmail.com>

On Mon, Sep 13, 2021 at 05:35:36AM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 10 quoted lines

> I think this v2 should address the comments Jeff King had in
> https://lore.kernel.org/git/YT6BnnXeAWn8BycF@coredump.intra.peff.net/;
> there's now an amended version of his proposed patch as part of this,
> but I prepended it with another one to prepare the "struct
> child_process" in cmd_difftool().
> 
> Doing so nicely gets around the question of the strvec memory
> management, since we can trust the run-command.c API to do that for
> us, but couldn't in my v1 when we'd copy our own "struct strvec *" to
> its "args".

Thanks for taking my suggestions into account. I like this approach, and I don't see any bugs. I replied separately to patch 3 with some further opportunities for cleanup, but with or without them, this is all a strict improvement.

-Peff