Re: [PATCH v3 0/6] tr2: plug memory leaks + logic errors + Win32 & Linux feature parity

From: Taylor Blau <me@ttaylorr.com>
Date: Aug 31, 2021, 00:17 UTC
Message-ID: <YS11MuO6j9N1mzvm@nand.local>
In-Reply-To: <cover-v3-0.6-0000000000-20210827T080054Z-avarab@gmail.com>

On Fri, Aug 27, 2021 at 10:02:12AM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 11 quoted lines

> Range-diff against v2:
> 1:  8c649ce3b4 = 1:  306f14a0f7 tr2: remove NEEDSWORK comment for "non-procfs" implementations
> 2:  0150e3402a = 2:  a999e016a9 tr2: clarify TRACE2_PROCESS_INFO_EXIT comment under Linux
> 3:  1d835d6767 = 3:  45769da953 tr2: stop leaking "thread_name" memory
> 4:  1aa0dbc394 ! 4:  946140691f tr2: fix memory leak & logic error in 2f732bf15e6
>     @@ Metadata
>      Author: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
>
>       ## Commit message ##
>     -    tr2: fix memory leak & logic error in 2f732bf15e6
>     +    tr2: leave the parent list empty upon failure & don't leak memory

I agree with Junio that the earlier subject line could be improved, but the replacement is a little verbose for my taste. On the other hand, I'm not sure how to simplify it without it becoming:

    tr2: memory leaks and bug fixes

;-).

So I think that what you wrote here is perfectly good. This version looks good to me, too.

Thanks, Taylor