Re: What's cooking in git.git (Aug 2021, #03; Fri, 6)

> On Mon, Aug 9, 2021 at 10:17 AM Junio C Hamano <gitster@pobox.com> wrote:
> >
> > Elijah Newren <newren@gmail.com> writes:
> >
> > > On Fri, Aug 6, 2021 at 6:26 PM Junio C Hamano <gitster@pobox.com> wrote:
> > >
> > >> * jt/push-negotiation-fixes (2021-07-15) 3 commits
> > >>  - fetch: die on invalid --negotiation-tip hash
> > >>  - send-pack: fix push nego. when remote has refs
> > >>  - send-pack: fix push.negotiate with remote helper
> > >>
> > >>  Bugfix for common ancestor negotiation recently introduced in "git
> > >>  push" codepath.
> > >>
> > >>  Needs review.
> > >
> > > I decided to take a look.
> [...]
> >
> > I am mostly worried about the lack of response to comments on [2/3],
> > especially to Peff's "Wouldn't this also be a problem for
> > multi-round fetch?".
> 
> Oh, I read Peff's comments[1] to mean that he thought Jonathan's
> patches behaved no worse than the existing code in the face of
> simultaneously running gc's, and thus that Ævar's concerns shouldn't
> hold up Jonathan's patches.  But, it's totally possible I
> misunderstood his intent -- as I mentioned, I'm not at all familiar
> with this area of the code.  Maybe Peff or Jonathan can clarify.