Re: What's cooking in git.git (Aug 2021, #03; Fri, 6)

From: Elijah Newren <newren@gmail.com>
Date: Aug 7, 2021, 16:29 UTC
Message-ID: <CABPp-BFOusrK6E6n91XSXcKP8kin-8RX8L_HXdKRjS790HkwHQ@mail.gmail.com>
In-Reply-To: <xmqqzgtuf6r0.fsf@gitster.g>

On Fri, Aug 6, 2021 at 6:26 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 9 quoted lines

> * jt/push-negotiation-fixes (2021-07-15) 3 commits
>  - fetch: die on invalid --negotiation-tip hash
>  - send-pack: fix push nego. when remote has refs
>  - send-pack: fix push.negotiate with remote helper
>
>  Bugfix for common ancestor negotiation recently introduced in "git
>  push" codepath.
>
>  Needs review.

I decided to take a look. It appears both Emily and Ævar have reviewed previously. Ævar brought up some comments on v2 of patch 2, but Jonathan responded to them all (and Peff chimed in as well), and there has been no further response from Ævar leaving the impression to me that Jonathan has replied to all feedback.

I'm not at all familiar with the protocol areas of the code, but I tried to read over the patches too. I think it'd have been a bit easier to understand for someone unfamiliar with this area if there were separate patches that introduced test_expect_failure showing the particular failures being fixed, followed by fixes in subsequent patches. I also noticed a stray newline removal in patch 2. Those are pretty minor issues, though, and I didn't spot anything substantial.