git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git revert --continue --no-verify

From
Taylor Blau <me@ttaylorr.com>
Date
Aug 5, 2021, 01:40 UTC
Message-ID
<YQtBezRE3l09cILa@nand.local>
In-Reply-To
<74443c64-efe9-ea47-e918-d62b8c976abc@gmail.com>
On Wed, Aug 04, 2021 at 07:14:34PM +0100, Phillip Wood wrote:
Show 6 quoted lines
> [...] I wouldn't be opposed to someone adding support for --no-verify
> (and --no-edit) to "cherry-pick/revert/rebase --continue" on the
> understanding that it only applied when committing the conflict
> resolution. There is a possible confusion for users though who might
> expect that the options passed with '--continue' applied to all the
> commits made by the command.

Yeah, that feels like we are just trying to confuse the user ;). So I agree that I'd rather not go any further along that direction.

Show 10 quoted lines
> do_commit() does not change the flags that it is called with - callers that
> want VERIFY_MSG will set that before they call do_commit(). do_commit() is
> there to commit simple picks without forking 'git commit'
>
> > So I suspect that this is an oversight, but perhaps somebody more
> > familiar with this code could confirm my thinking.
>
> I hope the above helps - basically the idea is "if the commit has been
> edited use VERIFY_MSG" and --continue unhelpfully uses a completely
> different code-path to the main commit picking/reverting loop.
Makes sense, thanks.
Taylor
Previous: Phillip WoodNext: Cameron Steffen
Message 9 of 10 in “git revert --continue --no-verify”
  1. Cameron SteffenAug 3, 2021
  2. Taylor BlauAug 3, 2021
  3. Cameron SteffenAug 3, 2021
  4. Taylor BlauAug 3, 2021
  5. Cameron SteffenAug 3, 2021
  6. Taylor BlauAug 3, 2021
  7. Junio C HamanoAug 4, 2021
  8. Phillip WoodAug 4, 2021
  9. Taylor BlauAug 5, 2021
  10. Cameron SteffenAug 5, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.