Re: [PATCH 6/6] git-compat-util.h: add __attribute__((printf)) to git_*printf*
- From
Jeff King <peff@peff.net>
- Date
- Jul 12, 2021, 20:13 UTC
- Message-ID
- <YOyiTTbFJmWjwXlq@coredump.intra.peff.net>
- In-Reply-To
- <patch-6.6-365c5cf50b6-20210710T084445Z-avarab@gmail.com>
On Sat, Jul 10, 2021 at 10:47:32AM +0200, Ævar Arnfjörð Bjarmason wrote:
Show 11 quoted lines
> Add __attribute__((printf)) to the compatibility functions we use > under SNPRINTF_RETURNS_BOGUS=Y. > > In practice this is redundant to the compiler's default printf format > checking, since we mostly (entirely?) develop and test on platforms > where SNPRINTF_RETURNS_BOGUS is not set. I'm doing this mainly for > consistency with other code, now we don't need to think about why this > particular case is different. > > See c4582f93a26 (Add compat/snprintf.c for systems that return bogus, > 2008-03-05) for the commit that added these functions.
I'm slightly lukewarm on general on adding this to a compat function. Those are meant to be a lowest-common-denominator fallback, and we usually avoid fancy features or our usual styles there in favor of simplicity.
I guess this probably isn't _hurting_ anything, but it makes me wonder how many systems have a broken snprintf _and_ support the attribute.
-Peff