Re: [PATCH v2 0/6] add missing attribute((format))

From: Jeff King <peff@peff.net>
Date: Jul 13, 2021, 21:17 UTC
Message-ID: <YO4C+dq3KjxInyp6@coredump.intra.peff.net>
In-Reply-To: <cover-0.6-0000000000-20210713T080411Z-avarab@gmail.com>

On Tue, Jul 13, 2021 at 10:05:15AM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 11 quoted lines

> Adds missing add missing __attribute__((format)) in various places,
> which improves compile-time checking.
> 
> v2: Let's drop the whole bending over backwards to do mostly/entirely
> useless strftime() checking. That's gone, I added a patch at the end
> with a comment for strbuf_addftime() to say why it's not there, and
> also split up the advise_if_enabled() change into its own commit.
> 
> I also removed the other cases of adding attribute checking to
> compat/*. I can't easily test those, and I don't know if there's
> potential bad interactions with git-compat-util.h.

Thanks. Modulo a whitespace typo in the final patch, these all look good to me.

I could take or leave the final patch, as I never wondered about strftime format-checking in the first place. :) But I don't mind it either way (the alternative is that the v1 discussion in the list could serve the purpose).

-Peff

Re: [PATCH v2 0/6] add missing __attribute__((format))

Re: [PATCH v2 0/6] add missing attribute((format))