git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Antw: [EXT] Re: git add --interactive patch improvement for split hunks

From
Jeff King <peff@peff.net>
Date
Jun 30, 2021, 17:06 UTC
Message-ID
<YNykmFejFG8cEjue@coredump.intra.peff.net>
In-Reply-To
<874kdfg32w.fsf@evledraar.gmail.com>
On Wed, Jun 30, 2021 at 10:27:16AM +0200, Ævar Arnfjörð Bjarmason wrote:
Show 15 quoted lines
> > I'm not sure. I think the topic would have graduated if either you had
> > just applied the squash and merged it down, or if the original author
> > had checked back in over the intervening year to say "hey, what happened
> > to my patch" (either by reading "what's cooking" or manually).
> >
> > I suspect drive-by contributors might not realize they need to do the
> > latter in some cases, but I wouldn't have counted 2014-era Ævar in that
> > boat. So I dunno.
> 
> Or maybe the moral of the story that it's a net addition of complexity
> to git-add--interactive.perl. If I didn't care enough to remember or
> notice the issue again maybe it wasn't all that important to begin with.
> 
> Likewise when it got ejected nobody else seemed to notice/care enough to
> say "hey I liked that feature" & to pick it up.
Yeah, that's probably a fair interpretation, too. :)
Show 7 quoted lines
> I'd entirely forgotten I wrote that. Now that I'm reminded of it I don't
> care enough myself to rebase it, test it again, and especially not to
> figure out if/how it's going to interact with the new C implementation /
> add and adjust a test for the two.
> 
> But maybe someone else will, it would be neat if someone has more of an
> itch from the lack of that feature & wants to pick it up.

I can probably save you a little time/mental energy here: the C version already does what your patch was trying to do. Once we switch to it as the default, your patch would be obsolete anyway. :)

-Peff
Previous: Ævar Arnfjörð Bjarmason
Message 9 of 9 in “git add --interactive patch improvement for split hunks”
  1. Ulrich WindlJun 24, 2021
  2. Jeff KingJun 24, 2021
  3. Antw: [EXT] Re: git add --interactive patch improvement for split hunksUlrich Windl, Jun 28, 2021
  4. Ævar Arnfjörð BjarmasonJun 28, 2021
  5. Jeff KingJun 30, 2021
  6. Junio C HamanoJun 30, 2021
  7. Jeff KingJun 30, 2021
  8. Ævar Arnfjörð BjarmasonJun 30, 2021
  9. Jeff KingJun 30, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.