Re: Antw: [EXT] Re: git add --interactive patch improvement for split hunks

From: Jeff King <peff@peff.net>
Date: Jun 30, 2021, 07:31 UTC
Message-ID: <YNwd6wmt4FTyySgH@coredump.intra.peff.net>
In-Reply-To: <xmqq5yxvvq7k.fsf@gitster.g>

On Tue, Jun 29, 2021 at 11:09:19PM -0700, Junio C Hamano wrote:

Show 12 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> >     It looks like Junio carried it in "What's Cooking" for almost a
> >     year, marked as "waiting for re-roll" to handle the squash, but then
> >     eventually discarded it as stale. :(
> 
> Heh, thanks for digging.
> 
> Is the moral of the story that we should merge down unfinished
> topics more aggressively (hoping that the untied loose ends would be
> tied after they hit released version), we should prod owners of
> stalled topics with sharper stick more often, or something else?

I'm not sure. I think the topic would have graduated if either you had just applied the squash and merged it down, or if the original author had checked back in over the intervening year to say "hey, what happened to my patch" (either by reading "what's cooking" or manually).

I suspect drive-by contributors might not realize they need to do the latter in some cases, but I wouldn't have counted 2014-era Ævar in that boat. So I dunno.

-Peff