git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] test: fix for TEST_OUTPUT_DIRECTORY

From
Jeff King <peff@peff.net>
Date
Jun 15, 2021, 11:23 UTC
Message-ID
<YMiNyVUjeLrWt9iH@coredump.intra.peff.net>
In-Reply-To
<3caba1f7-026d-827e-d97a-8b5708dd9765@gmail.com>
On Tue, Jun 15, 2021 at 06:21:00PM +0700, Bagas Sanjaya wrote:
Show 7 quoted lines
> On 15/06/21 18.10, Jeff King wrote:
> > I think it's just that the aggregation script was never meant to signal
> > to "make". In a regular "make test" (not using prove), each individual
> > test script is a dependency than can fail on its own. That means a
> > failure of any of them will signal "make" to fail the overall operation.
> > 
> Only one failure can trigger FTBFS when make test, right?

I'm not sure I understand what your question means. I know that "FTBFS" means "failed to build from source", but that is not a term we use in the Git project. So if you are asking whether "make test" will exit non-zero if a single test fails, then yes.

If you're asking whether a Debian package would consider that an FTBFS, then probably yes, but it depends on whether they run the tests.

-Peff
Previous: Bagas SanjayaNext: Felipe Contreras
Message 11 of 13 in “test: fix for TEST_OUTPUT_DIRECTORY”
  1. test: fix for TEST_OUTPUT_DIRECTORYFelipe Contreras, Jun 9, 2021
  2. Jeff KingJun 13, 2021
  3. Felipe ContrerasJun 13, 2021
  4. Jeff KingJun 14, 2021
  5. Felipe ContrerasJun 14, 2021
  6. Ævar Arnfjörð BjarmasonJun 14, 2021
  7. Jeff KingJun 14, 2021
  8. Ævar Arnfjörð BjarmasonJun 14, 2021
  9. Jeff KingJun 15, 2021
  10. Bagas SanjayaJun 15, 2021
  11. Jeff KingJun 15, 2021
  12. Felipe ContrerasJun 15, 2021
  13. Felipe ContrerasJun 15, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.