Re: [PATCH] test: fix for TEST_OUTPUT_DIRECTORY

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Jun 15, 2021, 18:09 UTC
Message-ID: <60c8eceeae8e8_12c2820895@natae.notmuch>
In-Reply-To: <YMiKlmY3B/1cDrr8@coredump.intra.peff.net>

Jeff King wrote:

> On Mon, Jun 14, 2021 at 06:55:03PM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 10 quoted lines

> > >   mkdir: cannot create directory ‘/dev/null’: Not a directory
> > >
> > > or similar.
> > 
> > Yeah that error sucks, but nobody will see it unless they're hacking on
> > the guts of this $TEST_NO_RESULTS_OUTPUT, and I think it beats being fragile.
> 
> I think that's a good point. You're unlikely to stumble into
> accidentally using TEST_NO_RESULTS_OUTPUT, so it might not be worth
> caring about too much.

But check_sub_test_lib_test() cares:

  test_must_be_empty err

  'err' is not empty, it contains:
  mkdir: cannot create directory '/dev/null': File exists
  /home/felipec/dev/git.git/git/t/test-lib.sh: line 1133: /dev/null.counts: Permission denied
  not ok 5 - pretend we have a fully passing test suite

-- 
Felipe Contreras