Re: [PATCH 1/2] [GSOC] cat-file: fix --batch report changed-type bug

From: Jeff King <peff@peff.net>
Date: Jun 3, 2021, 19:28 UTC
Message-ID: <YLktazqb0yY5LK/V@coredump.intra.peff.net>
In-Reply-To: <CAOLTT8QMpMV=7A4ZP2k5YUrqjznBwh_uDv+qvC7Meq3pwvZt1g@mail.gmail.com>

On Thu, Jun 03, 2021 at 03:18:43PM +0800, ZheNing Hu wrote:

Show 11 quoted lines

> Jeff King <peff@peff.net> 于2021年6月3日周四 上午4:01写道：
> >
> >   This assumption was broken by 845de33a5b (cat-file: avoid noop calls
> >   to sha1_object_info_extended, 2016-05-18). That commit skips the call
> >   to oid_object_info_extended() entirely when --batch-all-objects is in
> >   use, and the custom format does not include any placeholders that
> >   require calling it.
> >
> 
> Or when the custom format only include placeholders like %(objectname) or
> %(rest), oid_object_info_extended() will not get the type of the object.

Yeah, that's what I was trying to get at with "placeholders that require calling it", but I couldn't think of a less awkward way to say that. :) Spelling it out is probably a good idea.

-Peff