Re: [ANNOUNCE] Git v2.32.0-rc3 - t5300 Still Broken on NonStop ia64/x86

From: Taylor Blau <me@ttaylorr.com>
Date: Jun 2, 2021, 20:18 UTC
Message-ID: <YLfnnkl3UfuU6Yo/@nand.local>
In-Reply-To: <YLfmo8kl0URnGgp5@coredump.intra.peff.net>

On Wed, Jun 02, 2021 at 04:14:27PM -0400, Jeff King wrote:

Show 6 quoted lines

> > The wrapper should apply to all platforms.  NFS (and presumably
> > other network FSes) can be mounted with interrupts enabled.
>
> I don't mind that, as the wrapper is pretty low-cost (and one less
> Makefile knob is nice). If it's widespread, though, I find it curious
> that nobody has run into it before now.

Yeah, I find it curious as well. I agree that the wrapper is relatively cheap (especially relative to fsync), but it seems unnecessary despite what's in POSIX's fsync(3). So the more conservative choice to me would be to hide it behind a Makefile knob, but I don't mind much either way.

Thanks, Taylor