git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [ANNOUNCE] Git v2.32.0-rc3 - t5300 Still Broken on NonStop ia64/x86

From
EWEric Wong <e@80x24.org>
Date
Jun 2, 2021, 20:11 UTC
Message-ID
<20210602201150.GA29388@dcvr>
In-Reply-To
<YLfgy94sbmStC0mR@coredump.intra.peff.net>
Jeff King <peff@peff.net> wrote:
Show 10 quoted lines
> And so when he gets this error:
> 
>   fatal: fsync error on '.git/objects/pack/tmp_pack_NkPgqN': Interrupted system call
> 
> presumably we were in fsync() when the signal arrived, and unlike most
> other platforms, the call needs to be restarted manually (even though we
> set up the signal with SA_RESTART). I'm not sure if this violates POSIX
> or not (I couldn't find a definitive answer to the set of interruptible
> functions in the standard). But either way, the workaround is probably
> something like:

"man 3posix fsync" says EINTR is allowed ("manpages-posix-dev" package in Debian non-free).

>   #ifdef FSYNC_NEEDS_RESTART

The wrapper should apply to all platforms. NFS (and presumably other network FSes) can be mounted with interrupts enabled.

Show 8 quoted lines
>   #undef fsync /* we'd define to git_fsync() in a header file */
>   static int git_fsync(int fd)
>   {
> 	int ret;
> 	while ((ret = fsync(fd)) < 0 && errno == EINTR)
> 		; /* try again */
> 	return ret;
>   }
Looks fine.
Previous: Junio C HamanoNext: Jeff King
Message 15 of 22 in “RE: [ANNOUNCE] Git v2.32.0-rc3 - t5300 Still Broken on NonStop ia64/x86”
  1. Randall S. BeckerJun 2, 2021
  2. Taylor BlauJun 2, 2021
  3. Jeff KingJun 2, 2021
  4. Taylor BlauJun 2, 2021
  5. Jeff KingJun 2, 2021
  6. Randall S. BeckerJun 2, 2021
  7. Junio C HamanoJun 4, 2021
  8. Taylor BlauJun 4, 2021
  9. Jeff KingJun 4, 2021
  10. Junio C HamanoJun 4, 2021
  11. Randall S. BeckerJun 6, 2021
  12. Jeff KingJun 8, 2021
  13. René ScharfeJun 5, 2021
  14. Junio C HamanoJun 5, 2021
  15. Eric WongJun 2, 2021
  16. Jeff KingJun 2, 2021
  17. Taylor BlauJun 2, 2021
  18. Randall S. BeckerJun 2, 2021
  19. Jeff KingJun 3, 2021
  20. Randall S. BeckerJun 3, 2021
  21. Bryan TurnerJun 3, 2021
  22. Randall S. BeckerJun 3, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.