Re: [PATCH] clone: caveat note on converting partial clone

From: Jeff King <peff@peff.net>
Date: May 30, 2021, 21:47 UTC
Message-ID: <YLQH7i5IPSdBnDko@coredump.intra.peff.net>
In-Reply-To: <20210529120730.38472-1-bagasdotme@gmail.com>

On Sat, May 29, 2021 at 07:07:31PM +0700, Bagas Sanjaya wrote:

Show 11 quoted lines

> Currently partial clones can't be converted into full clones, because
> there is an issue where the remote can't send all missing objects
> required.
> 
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> ---
>  This patch is based on "clone: document partial clone section" by Teng
>  Long [1].
> 
>  [1]:
> https://lore.kernel.org/git/pull.745.v5.git.git.1614695133486.gitgitgadget@gmail.com/

Wouldn't:

  git -c fetch.negotiationAlgorithm=noop fetch ...

work?

IMHO that is not ideal, and I would like to see it work even when we provide "have" lines to the server. But if we are going to tell users something in the documentation, pointing them to this technique is probably much more helpful than saying "it can't be done".

-Peff