Re: [PATCH] clone: caveat note on converting partial clone

From: Derrick Stolee <stolee@gmail.com>
Date: Jun 1, 2021, 10:46 UTC
Message-ID: <08cfd066-dda5-40a7-8467-5e621e0ea619@gmail.com>
In-Reply-To: <YLQH7i5IPSdBnDko@coredump.intra.peff.net>

On 5/30/21 5:47 PM, Jeff King wrote:

Show 24 quoted lines

> On Sat, May 29, 2021 at 07:07:31PM +0700, Bagas Sanjaya wrote:
> 
>> Currently partial clones can't be converted into full clones, because
>> there is an issue where the remote can't send all missing objects
>> required.
>>
>> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
>> ---
>>  This patch is based on "clone: document partial clone section" by Teng
>>  Long [1].
>>
>>  [1]:
>> https://lore.kernel.org/git/pull.745.v5.git.git.1614695133486.gitgitgadget@gmail.com/
> 
> Wouldn't:
> 
>   git -c fetch.negotiationAlgorithm=noop fetch ...
> 
> work?
> 
> IMHO that is not ideal, and I would like to see it work even when we
> provide "have" lines to the server. But if we are going to tell users
> something in the documentation, pointing them to this technique is
> probably much more helpful than saying "it can't be done".

Any workaround is better than none.

At minimum, I would expect a summary of the discussion instead of a pointer to a mailing list thread.

Thanks, -Stolee