Re: CI: 'seen' minus a few passes tests, eh, almost

From: Jeff King <peff@peff.net>
Date: May 26, 2021, 15:53 UTC
Message-ID: <YK5u/qxFJUr9d/qS@coredump.intra.peff.net>
In-Reply-To: <YK5dubBcSwm9c4Ta@nand.local>

On Wed, May 26, 2021 at 10:39:53AM -0400, Taylor Blau wrote:

Show 12 quoted lines

> On Wed, May 26, 2021 at 02:32:19PM +0900, Junio C Hamano wrote:
> > Just with a hunch, I further excluded tb/multi-pack-bitmaps from
> > 'seen', in addition to these four topics.  It seems to pass the
> > whole test suite on both 32- and 64-bit build combinations.
> >
> >     https://github.com/git/git/actions/runs/877225207
> >
> > Except that vs-build sometimes fails to download the sdk, that is.
> 
> Thanks for letting me know. I have accumulated a few local changes that
> I wanted to include in a reroll of that topic, but I was waiting on
> other reviewer eyes before sending it.

I think the best thing in a situation like this (where reviewers like me have been very slow to respond) is to repost it explaining the situation. That makes it clear what the current state is, and brings it to the forefront of the list's attention (both reviewers you'd expect to look at it, but people in general). Doing that too often can be obnoxious, of course, but after 6-8 weeks saying "hey, this didn't get attention; can anybody take a look at it?" is perfectly reasonable.

> I should be able to spend some more time pushing that topic forward
> after the release. There are a few other patch series waiting on it from
> GitHub, too.

But yeah, waiting until after the release is good, to keep attention on regression fixes in the meantime.

-Peff