Re: CI: 'seen' minus a few passes tests, eh, almost

From: Taylor Blau <me@ttaylorr.com>
Date: May 26, 2021, 16:48 UTC
Message-ID: <YK5754JqOUXL/+/L@nand.local>
In-Reply-To: <YK5u/qxFJUr9d/qS@coredump.intra.peff.net>

On Wed, May 26, 2021 at 11:53:34AM -0400, Jeff King wrote:

Show 22 quoted lines

> On Wed, May 26, 2021 at 10:39:53AM -0400, Taylor Blau wrote:
>
> > On Wed, May 26, 2021 at 02:32:19PM +0900, Junio C Hamano wrote:
> > > Just with a hunch, I further excluded tb/multi-pack-bitmaps from
> > > 'seen', in addition to these four topics.  It seems to pass the
> > > whole test suite on both 32- and 64-bit build combinations.
> > >
> > >     https://github.com/git/git/actions/runs/877225207
> > >
> > > Except that vs-build sometimes fails to download the sdk, that is.
> >
> > Thanks for letting me know. I have accumulated a few local changes that
> > I wanted to include in a reroll of that topic, but I was waiting on
> > other reviewer eyes before sending it.
>
> I think the best thing in a situation like this (where reviewers like me
> have been very slow to respond) is to repost it explaining the
> situation. That makes it clear what the current state is, and brings it
> to the forefront of the list's attention (both reviewers you'd expect to
> look at it, but people in general). Doing that too often can be
> obnoxious, of course, but after 6-8 weeks saying "hey, this didn't get
> attention; can anybody take a look at it?" is perfectly reasonable.

Indeed, but I had been putting even doing that off. I've had some sporadic time off in the last few months (as you know) and so usually by the time that I'm back enough other stuff has accumulated that I don't feel like adding more to the list by encouraging further review.

So the topic (and my participation on the list in general) has kind of languished, but I'm hoping that since things have mostly cooled down for me outside of work that I'll be able to participate and submit patches more consistently.

Thanks, Taylor