Re: [PATCH 2/2] git: support separate arg for `--config-env`'s value
On Tue, Apr 20, 2021 at 12:52:43PM +0200, Ævar Arnfjörð Bjarmason wrote:
Show 6 quoted lines
> > Mitigate this inconsistency by accepting both syntaxes and add tests to
> > verify both work.
> >
> > Signed-off-by: Patrick Steinhardt <ps@pks.im>
>
> This whole series LGTM.
Me too. Thanks for finding it (and Patrick for fixing it).
Show 11 quoted lines
> > + } else if (!strcmp(cmd, "--config-env")) {
> > + if (*argc < 2) {
> > + fprintf(stderr, _("no config key given for --config-env\n" ));
>
>
> I found this use of fprintf() slightly odd, why not error(), but then
> went back and read the function and saw that it has N number of
> "fprintf(stderr, [...])" already.
>
> That could probably all be converted to error(), but better to be
> consistent for now.Yep. Likewise the weird extra space at the end of the string.
-Peff
Jeff King <peff@peff.net>