Re: [PATCH 2/2] git: support separate arg for `--config-env`'s value

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Apr 20, 2021, 11:24 UTC
Message-ID: <87sg3l2o7r.fsf@evledraar.gmail.com>
In-Reply-To: <d52db89bc2f40a9df5e9fafe4e1bb8c173a7f45f.1618847606.git.ps@pks.im>

On Mon, Apr 19 2021, Patrick Steinhardt wrote:

Show 7 quoted lines

> +test_expect_success 'git --config-env with missing value' '
> +	test_must_fail env ENVVAR=value git --config-env 2>error &&
> +	test_i18ngrep "no config key given for --config-env" error &&
> +	test_must_fail env ENVVAR=value git --config-env config core.name 2>error &&
> +	test_i18ngrep "invalid config format: config" error
> +'
> +

Nit: (not spotted on the first reading): s/test_i18ngrep/grep/.

>  test_expect_success 'git --config-env fails with invalid parameters' '
>  	test_must_fail git --config-env=foo.flag config --bool foo.flag 2>error &&
>  	test_i18ngrep "invalid config format: foo.flag" error &&