git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t: annotate !PTHREADS tests with !FAIL_PREREQS

From
Jeff King <peff@peff.net>
Date
Mar 18, 2021, 21:53 UTC
Message-ID
<YFPL0F4C7mfDazOW@coredump.intra.peff.net>
In-Reply-To
<xmqqblbgrwkg.fsf@gitster.g>
On Thu, Mar 18, 2021 at 02:17:19PM -0700, Junio C Hamano wrote:
> In short, the biggest mistake in the current FAIL_PREREQS design is
> to hook into test_have_prereq while the stated objective only needs
> to futz with the prerequisite given to the test_expect_* functions,
> I would think.
Yeah, that matches my intuition of the problem, too.
-Peff
Previous: Junio C Hamano
Message 10 of 10 in “Tests failed with GIT_TEST_FAIL_PREREQS and/or GIT_TEST_PROTOCOL_VERSION”
  1. Son Luong NgocMar 16, 2021
  2. Taylor BlauMar 16, 2021
  3. Son Luong NgocMar 17, 2021
  4. t5606: run clone branch name test with protocol v2Jonathan Tan, Mar 17, 2021
  5. Jeff KingMar 17, 2021
  6. Junio C HamanoMar 17, 2021
  7. Jeff KingMar 17, 2021
  8. t: annotate !PTHREADS tests with !FAIL_PREREQSJeff King, Mar 17, 2021
  9. Junio C HamanoMar 18, 2021
  10. Jeff KingMar 18, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.