git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t5606: run clone branch name test with protocol v2

From
JTJonathan Tan <jonathantanmy@google.com>
Date
Mar 17, 2021, 15:42 UTC
Message-ID
<20210317154200.2656837-1-jonathantanmy@google.com>
In-Reply-To
<YFIGSo3U5u7zy9fq@C02YX140LVDN.corpad.adbkng.com>

4f37d45706 ("clone: respect remote unborn HEAD", 2021-02-05) introduces a new feature (if the remote has an unborn HEAD, e.g. when the remote repository is empty, use it as the name of the branch) that only works in protocol v2, but did not ensure that one of its tests always uses protocol v2, and thus that test would fail if GIT_TEST_PROTOCOL_VERSION=0 (or 1) is used. Therefore, add "-c protocol.version=2" to the appropriate test.

(The rest of the tests from that commit have "-c protocol.version=2" already added.)

Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
---
Thanks, Son Luong, for noticing this. Here's a fix for the
GIT_TEST_PROTOCOL_VERSION part. This was built on 4f37d45706 but also
applies cleanly on master.
 t/t5606-clone-options.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t5606-clone-options.sh b/t/t5606-clone-options.sh
index ca6339a5fb..5e30772735 100755
--- a/t/t5606-clone-options.sh
+++ b/t/t5606-clone-options.sh
@@ -106,7 +106,7 @@ test_expect_success 'chooses correct default initial branch name' '
 	git -c init.defaultBranch=foo init --bare empty &&
 	test_config -C empty lsrefs.unborn advertise &&
 	GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME= \
-	git -c init.defaultBranch=up clone empty whats-up &&
+	git -c init.defaultBranch=up -c protocol.version=2 clone empty whats-up &&
 	test refs/heads/foo = $(git -C whats-up symbolic-ref HEAD) &&
 	test refs/heads/foo = $(git -C whats-up config branch.foo.merge)
 '
-- 
2.31.0.rc2.261.g7f71774620-goog
Previous: Son Luong NgocNext: Jeff King
Message 4 of 10 in “Tests failed with GIT_TEST_FAIL_PREREQS and/or GIT_TEST_PROTOCOL_VERSION”
  1. Son Luong NgocMar 16, 2021
  2. Taylor BlauMar 16, 2021
  3. Son Luong NgocMar 17, 2021
  4. t5606: run clone branch name test with protocol v2Jonathan Tan, Mar 17, 2021
  5. Jeff KingMar 17, 2021
  6. Junio C HamanoMar 17, 2021
  7. Jeff KingMar 17, 2021
  8. t: annotate !PTHREADS tests with !FAIL_PREREQSJeff King, Mar 17, 2021
  9. Junio C HamanoMar 18, 2021
  10. Jeff KingMar 18, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.