Re: [PATCH v2 2/3] ls-refs.c: initialize 'prefixes' before using it

From: Jeff King <peff@peff.net>
Date: Jan 20, 2021, 19:58 UTC
Message-ID: <YAiLXUDTdMpdGG5b@coredump.intra.peff.net>
In-Reply-To: <5fc081b2d554db305400ec52fac8683a3ed59597.1611158549.git.me@ttaylorr.com>

On Wed, Jan 20, 2021 at 11:04:25AM -0500, Taylor Blau wrote:

Show 9 quoted lines

> From: Jacob Vosmaer <jacob@gitlab.com>
> 
> Correctly initialize the "prefixes" strvec using strvec_init() instead
> of simply zeroing it via the earlier memset().
> 
> There's no way to trigger a crash, since the first 'ref-prefix' command
> will initialize the strvec via the 'ALLOC_GROW' in 'strvec_push_nodup()'
> (the alloc and nr variables are already zero'd, so the call to
> ALLOC_GROW is valid).

For people not familiar with strvec, I think there's a missing bit of explanation between those two paragraphs: an initialized strvec does not point to NULL, but to a dummy array with a single NULL value in it. That explains why it might crash. :)

That nit (and the one I mentioned in the previous patch) aside, these patches look good to me (and I am OK with or without the nits addressed).

-Peff