Re: [PATCH v2 1/3] refs: expose 'for_each_fullref_in_prefixes'

From: Jeff King <peff@peff.net>
Date: Jan 20, 2021, 19:56 UTC
Message-ID: <YAiK4U1KnjPtWFN6@coredump.intra.peff.net>
In-Reply-To: <bda314fe7ae1629ba068a0c4ada9b6adc20576eb.1611158549.git.me@ttaylorr.com>

On Wed, Jan 20, 2021 at 11:04:21AM -0500, Taylor Blau wrote:

Show 13 quoted lines

> This function was used in the ref-filter.c code to find the longest
> common prefix of among a set of refspecs, and then to iterate all of the
> references that descend from that prefix.
> 
> A future patch will want to use that same code from ls-refs.c, so
> prepare by exposing and moving it to refs.c. Since there is nothing
> specific to the ref-filter code here (other than that it was previously
> the only caller of this function), this really belongs in the more
> generic refs.h header.
> 
> The code moved in this patch is identical before and after, with the one
> exception of renaming some arguments to be consistent with other
> functions exposed in refs.h.

The other non-identical thing is that it handles a namespace parameter (which is good, but an obvious non-movement).

-Peff