git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/3] Refactor writing promisor file

From
Jeff King <peff@peff.net>
Date
Jan 14, 2021, 20:11 UTC
Message-ID
<YAClgD7HNglz2LtV@coredump.intra.peff.net>
In-Reply-To
<20210114155016.3005932-1-chriscool@tuxfamily.org>
On Thu, Jan 14, 2021 at 04:50:13PM +0100, Christian Couder wrote:
Show 8 quoted lines
> This is a small patch series to refactor the code that actually writes
> a promisor file (<pack-name>.promisor) into a write_promisor_file()
> function, and then to improve it a bit.
> 
> Compared to version 1 of this patch series, the only difference is
> that patch 3/3 has been added to die() in case of error, instead of
> ignoring it, when actually writing the content of the file or closing
> it. Thanks to Peff and Taylor for their suggestions.
These look great to me. Thanks for adding the extra error handling.
-Peff
Previous: Taylor Blau
Message 6 of 6 in “Refactor writing promisor file”
  1. 0/3 Refactor writing promisor fileChristian Couder, Jan 14, 2021
  2. 1/3 fetch-pack: rename helper to create_promisor_file()Christian Couder, Jan 14, 2021
  3. 2/3 fetch-pack: refactor writing promisor fileChristian Couder, Jan 14, 2021
  4. 3/3 pack-write: die on error in write_promisor_file()Christian Couder, Jan 14, 2021
  5. Taylor BlauJan 14, 2021
  6. Jeff KingJan 14, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.