git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/3] Refactor writing promisor file

From
Christian Couder <christian.couder@gmail.com>
Date
Jan 14, 2021, 15:50 UTC
Message-ID
<20210114155016.3005932-1-chriscool@tuxfamily.org>

This is a small patch series to refactor the code that actually writes a promisor file (<pack-name>.promisor) into a write_promisor_file() function, and then to improve it a bit.

Compared to version 1 of this patch series, the only difference is that patch 3/3 has been added to die() in case of error, instead of ignoring it, when actually writing the content of the file or closing it. Thanks to Peff and Taylor for their suggestions.

Discussion about V1:
  https://lore.kernel.org/git/20210112082159.2277214-1-chriscool@tuxfamily.org/
Christian Couder (3):
  fetch-pack: rename helper to create_promisor_file()
  fetch-pack: refactor writing promisor file
  pack-write: die on error in write_promisor_file()
 builtin/repack.c |  8 +++-----
 fetch-pack.c     | 16 +++++-----------
 pack-write.c     | 16 ++++++++++++++++
 pack.h           |  4 ++++
 4 files changed, 28 insertions(+), 16 deletions(-)
-- 
2.30.0.83.g36fd80b35a.dirty
Next: Christian Couder
Message 1 of 6 in “Refactor writing promisor file”
  1. 0/3 Refactor writing promisor fileChristian Couder, Jan 14, 2021
  2. 1/3 fetch-pack: rename helper to create_promisor_file()Christian Couder, Jan 14, 2021
  3. 2/3 fetch-pack: refactor writing promisor fileChristian Couder, Jan 14, 2021
  4. 3/3 pack-write: die on error in write_promisor_file()Christian Couder, Jan 14, 2021
  5. Taylor BlauJan 14, 2021
  6. Jeff KingJan 14, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.