git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 9/9] userdiff: mark unused parameter in internal callback

From
Jeff King <peff@peff.net>
Date
Dec 13, 2022, 11:16 UTC
Message-ID
<Y5hfKWD84y72CFHK@coredump.intra.peff.net>
In-Reply-To
<Y5hdvpbLpXySHFRz@coredump.intra.peff.net>

Since f12fa9ee6c (userdiff: add and use for_each_userdiff_driver(), 2021-04-08), lookup of userdiffs is done with a generic for_each_userdiff_driver(). But the name lookup doesn't use the "type" field, of course.

We can't get rid of that field from the generic interface because it is used by t/helper/test-userdiff.c. So mark it as unused in this instance to silence -Wunused-parameter.

Signed-off-by: Jeff King <peff@peff.net>
---
 userdiff.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/userdiff.c b/userdiff.c
index 151d9a5278..e25356a061 100644
--- a/userdiff.c
+++ b/userdiff.c
@@ -315,7 +315,8 @@ struct find_by_namelen_data {
 };
 
 static int userdiff_find_by_namelen_cb(struct userdiff_driver *driver,
-				       enum userdiff_driver_type type, void *priv)
+				       enum userdiff_driver_type type UNUSED,
+				       void *priv)
 {
 	struct find_by_namelen_data *cb_data = priv;
 
-- 
2.39.0.546.g5ea984bc66
Previous: Jeff KingNext: Junio C Hamano
Message 10 of 11 in “more -Wunused-parameter fixes/annotations”
  1. 0/9 more -Wunused-parameter fixes/annotationsJeff King, Dec 13, 2022
  2. 1/9 ls-refs: use repository parameter to iterate refsJeff King, Dec 13, 2022
  3. 2/9 blob: drop unused parts of parse_blob_buffer()Jeff King, Dec 13, 2022
  4. 3/9 list-objects: drop process_gitlink() functionJeff King, Dec 13, 2022
  5. 4/9 ws: drop unused parameter from ws_blank_line()Jeff King, Dec 13, 2022
  6. 5/9 xdiff: drop unused parameter in def_ff()Jeff King, Dec 13, 2022
  7. 6/9 xdiff: mark unused parameter in xdl_call_hunk_func()Jeff King, Dec 13, 2022
  8. 7/9 diff: mark unused parameters in callbacksJeff King, Dec 13, 2022
  9. 8/9 list-objects-filter: mark unused parameters in virtual functionsJeff King, Dec 13, 2022
  10. 9/9 userdiff: mark unused parameter in internal callbackJeff King, Dec 13, 2022
  11. Junio C HamanoDec 14, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.