git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/9] more -Wunused-parameter fixes/annotations

From
Jeff King <peff@peff.net>
Date
Dec 13, 2022, 11:10 UTC
Message-ID
<Y5hdvpbLpXySHFRz@coredump.intra.peff.net>

This was supposed to just be annotations, but after staring at a few of the cases, I think we're better off removing the unused parameters. I've floated those ones up to the top of the series.

  [1/9]: ls-refs: use repository parameter to iterate refs
  [2/9]: blob: drop unused parts of parse_blob_buffer()
  [3/9]: list-objects: drop process_gitlink() function
  [4/9]: ws: drop unused parameter from ws_blank_line()
  [5/9]: xdiff: drop unused parameter in def_ff()
  [6/9]: xdiff: mark unused parameter in xdl_call_hunk_func()
  [7/9]: diff: mark unused parameters in callbacks
  [8/9]: list-objects-filter: mark unused parameters in virtual functions
  [9/9]: userdiff: mark unused parameter in internal callback
 add-interactive.c           |  2 +-
 apply.c                     |  4 ++--
 blob.c                      |  3 +--
 blob.h                      |  3 +--
 builtin/add.c               |  2 +-
 builtin/fast-export.c       |  2 +-
 builtin/merge-tree.c        |  2 +-
 builtin/merge.c             |  2 +-
 builtin/rerere.c            |  2 +-
 builtin/reset.c             |  3 ++-
 builtin/submodule--helper.c |  2 +-
 cache.h                     |  2 +-
 combine-diff.c              |  2 +-
 diff-lib.c                  |  2 +-
 diff.c                      | 18 +++++++++---------
 list-objects-filter.c       | 30 +++++++++++++++---------------
 list-objects.c              | 33 +--------------------------------
 ls-refs.c                   |  5 +++--
 object.c                    |  5 ++---
 range-diff.c                | 12 ++++++++----
 ref-filter.c                |  5 +++--
 refs.c                      |  9 +++++----
 refs.h                      |  6 ++++--
 revision.c                  | 25 +++++++++++++++----------
 submodule.c                 |  2 +-
 userdiff.c                  |  3 ++-
 ws.c                        |  2 +-
 wt-status.c                 |  4 ++--
 xdiff/xdiffi.c              |  2 +-
 xdiff/xemit.c               |  4 ++--
 30 files changed, 90 insertions(+), 108 deletions(-)
-Peff
Next: Jeff King
Message 1 of 11 in “more -Wunused-parameter fixes/annotations”
  1. 0/9 more -Wunused-parameter fixes/annotationsJeff King, Dec 13, 2022
  2. 1/9 ls-refs: use repository parameter to iterate refsJeff King, Dec 13, 2022
  3. 2/9 blob: drop unused parts of parse_blob_buffer()Jeff King, Dec 13, 2022
  4. 3/9 list-objects: drop process_gitlink() functionJeff King, Dec 13, 2022
  5. 4/9 ws: drop unused parameter from ws_blank_line()Jeff King, Dec 13, 2022
  6. 5/9 xdiff: drop unused parameter in def_ff()Jeff King, Dec 13, 2022
  7. 6/9 xdiff: mark unused parameter in xdl_call_hunk_func()Jeff King, Dec 13, 2022
  8. 7/9 diff: mark unused parameters in callbacksJeff King, Dec 13, 2022
  9. 8/9 list-objects-filter: mark unused parameters in virtual functionsJeff King, Dec 13, 2022
  10. 9/9 userdiff: mark unused parameter in internal callbackJeff King, Dec 13, 2022
  11. Junio C HamanoDec 14, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.