Re: ms/sendemail-validate-headers, was Re: What's cooking in git.git (Nov 2022, #03; Mon, 14)

From: Taylor Blau <me@ttaylorr.com>
Date: Nov 16, 2022, 01:20 UTC
Message-ID: <Y3Q69UlrmyCXLCsY@nand.local>
In-Reply-To: <4p90qnq3-580o-9n59-34n0-rs3pp635908o@tzk.qr>

On Tue, Nov 15, 2022 at 03:04:29PM +0100, Johannes Schindelin wrote:

Show 12 quoted lines

> Hi Taylor,
>
> On Mon, 14 Nov 2022, Taylor Blau wrote:
>
> > * ms/sendemail-validate-headers (2022-11-11) 1 commit
> >  - Expose header information to git-send-email's sendemail-validate hook
> >
> >  Expecting a reroll.
> >  source: <20221111194223.644845-2-michael.strawbridge@amd.com>
>
> I see this mail, but no replies. Is it really appropriate to label this as
> "Expecting a reroll"?

Thanks for spotting. I wrote this one from memory, but in retrospect I think I was thinking of a different thread [1] between the patch author and brian where there was some discussion (but no patches).

> A more appropriate label would be "Breaks t9001", I would think, and the
> reference should probable be <36s0r4s9-n21r-pop9-o7rn-q0qrq487p831@tzk.qr>
> instead (but I sent that out only a couple of minutes ago, so I would
> still be curious why it was marked as "Expecting a reroll").

Yes, let's keep this out of 'seen' since it has seen no review and breaks t9001. I'll update my notes accordingly, thanks.

Thanks, Taylor

[1]: https://lore.kernel.org/git/87czcm7maf.fsf@amd.com/#t