Re: ps/receive-use-only-advertised
- From
Jeff King <peff@peff.net>
- Date
- Nov 15, 2022, 17:28 UTC
- Message-ID
- <Y3PMLFuvR6hlIzbq@coredump.intra.peff.net>
- In-Reply-To
- <Y3M2Fq7pZk4lNY9G@nand.local>
On Tue, Nov 15, 2022 at 01:47:50AM -0500, Taylor Blau wrote:
Show 16 quoted lines
> > > "git receive-pack" used to use all the local refs as the boundary > > > for checking connectivity of the data "git push" sent, but now it > > > uses only the refs that it advertised to the pusher. In a > > > repository with the .hideRefs configuration, this reduces the > > > resource needed to perform the check, and also forces the pusher to > > > prove they have all objects that are necessary to complete the > > > history on top of only the history available to them. > > > > We have at a later point established that this is not true: the pusher > > does not have to prove they have all objects. As the `--not --all` part > > in git-rev-list(1) is merely an optimization the semantics aren't > > changed at all > > Thanks; this is Junio's description from when he picked up the topic > back in WC #08 from October. I'll need to update before graduating it > down.
Yeah, I think you can probably just remove everything from "and also forces..." on.
Show 8 quoted lines
> > I think this is stale, right? There was no further feedback until now, > > and in your [1] you say that things look good to you, but that you > > intend to wait a few days for further feedback. > > > > Thanks! > > Yes, that is indeed stale, thanks for catching. I'm just waiting for a > review from somebody that isn't you or me ;-).
I just left a review. It looks good to me to hit 'next'.
-Peff