Re: [PATCH v4 2/2] git-jump: invoke emacs/emacsclient
- From
Jeff King <peff@peff.net>
- Date
- Nov 24, 2022, 01:09 UTC
- Message-ID
- <Y37EPdUkBhsSPmRD@coredump.intra.peff.net>
- In-Reply-To
- <CAF5D8-vSsBsdiA8SiDgqUFkL9_3N-v+psVxj-AcibOB88gxWfA@mail.gmail.com>
On Wed, Nov 23, 2022 at 02:33:50PM +0900, Yoichi Nakayama wrote:
Show 10 quoted lines
> On Wed, Nov 23, 2022 at 3:54 AM Jeff King <peff@peff.net> wrote: > > Hmm, I know I suggested using a temporary file since "cat $tmpfile" > > should be pretty safe. But it does still have problems if your tmp > > directory has spaces. Or even other metacharacters, which I think will > > be interpreted by the eval, since $@ is expanded in the outermost level > > of the shell. > > Right. But the problem is not specific to emacs (it happens in vim too). > Let's fix it another time (as you noted, that's pretty unlikely, and we may > not even need to fix it).
Good point. The vim version is easier to fix (we just need to double-quote \$1 inside the eval), but the fact that nobody has complained is an indication that it does not really matter.
-Peff