Re: [PATCH 2/2] git-jump: invoke emacsclient
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Nov 19, 2022, 23:59 UTC
- Message-ID
- <CAPig+cR6+H2gqZbnj9FHzZRefwTjYme94kNeQ9qmVi-wLYZ6fw@mail.gmail.com>
- In-Reply-To
- <CAF5D8-ujg3Tp2s2+eGMgZfXXcZEyRKreAj=EkG0KiMniKjoKBQ@mail.gmail.com>
On Sat, Nov 19, 2022 at 6:44 PM Yoichi Nakayama <yoichi.nakayama@gmail.com> wrote:
Show 9 quoted lines
> On Sun, Nov 20, 2022 at 12:53 AM Eric Sunshine <sunshine@sunshineco.com> wrote: > > Would it make sense to expand this to support the VISUAL and EDITOR > > environment variables too? For instance, since I want to use Emacs for > > all my editing needs, I have EDITOR set to reference emacsclient. So, > > if GIT_EDITOR is unset, then check VISUAL, and if that is unset, check > > EDITOR. > > "git var GIT_EDITOR" does respect VISUAL and EDITOR environment variables. > See git-var(1) reference manual.
Excellent.
Show 6 quoted lines
> > Also, on macOS, I need to set EDITOR (or GIT_EDITOR or VISUAL) to the > > full path of emacsclient, but the regex used here is too tight to > > recognize that. Perhaps loosening it to just 'emacsclient' would be a > > good idea (as it seems unlikely to falsely match any other editor)? > > It is a good idea. Thanks!
Thanks.