Re: ab/make-bin-wrappers (was: What's cooking in git.git (Nov 2022, #01; Thu, 3))
On Tue, Nov 08, 2022 at 04:52:44PM -0500, Taylor Blau wrote:
Show 17 quoted lines
> > I don't have any strong opinion on that. I read the v2 cover letter, was
> > skeptical/confused of the motivation, and didn't go much further.
> >
> > Your explanation in the linked email is that there are _other_ reasons
> > to do this refactoring, but I don't have any knowledge there that would
> > add to the review. My gut is still that building bin-wrappers/foo
> > doesn't need to depend on foo, but if it's one line, I don't care that
> > much either way. If it was 50 lines of complicated Makefile refactoring,
> > then would probably not be worth it.
>
> Isn't this topic exactly the latter? IOW:
>
> $ git diff --stat master...ab/make-bin-wrappers
> Makefile | 72 ++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------
> 1 file changed, 52 insertions(+), 20 deletions(-)
>
> ...maybe that was exactly your point ;-).
Sorry, I perhaps could have made the last sentence more clear as:
If it was 50 lines of complicated Makefile refactoring _just_ to have
"make bin-wrappers/foo" depend on "foo", it would not be worth it. But
if it is doing something else, it might be. I don't have a strong
opinion because I haven't (and don't want to have) looked into that
"something else".
-Peff
Jeff King <peff@peff.net>