Re: What's cooking in git.git (Nov 2022, #01; Thu, 3)
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Nov 8, 2022, 21:49 UTC
- Message-ID
- <Y2rPAGp96IwrLS1T@nand.local>
- In-Reply-To
- <88b30b5f-2712-4c84-331c-2ea7338053ad@iee.email>
On Mon, Nov 07, 2022 at 12:19:22PM +0000, Philip Oakley wrote:
Show 29 quoted lines
> On 05/11/2022 00:26, Taylor Blau wrote: > > On Sat, Nov 05, 2022 at 12:21:23AM +0000, Philip Oakley wrote: > >> On 04/11/2022 01:05, Taylor Blau wrote: > >>> -------------------------------------------------- > >>> [Cooking] > >>> * po/pretty-hard-trunc (2022-11-02) 1 commit > >>> - pretty-formats: add hard truncation, without ellipsis, options > >>> > >>> Add a new pretty format which truncates without ellipsis. > >>> > >>> Missing test coverage. > >> Is that out of date? V3 did include tests in t4205 and t6006. > >> > >>> source: <20221102120853.2013-1-philipoakley@iee.email> > >> This source is the V3. > > Yes, thanks for catching. Indeed, the version that I have at: > > > > git@github.com:ttaylorr/git.git > > > > on po/pretty-hard-trunc has the new tests. I think we are still waiting > > for review on that topic, though... > > > > Thanks, > > Taylor > An extra review would be useful. > > I wasn't certain about the use of `qz_to_tab_space` in the here-doc > formulation of t6006-rev-list-format where some of the new tests now > included trailing spaces (but others didn't).
Let's wait for a little more review before we start merging this one down. I'll try and take a look if others don't beat me to it shortly.
Thanks, Taylor