Re: [PATCH 0/4] chainlint: improve annotated output

From: Taylor Blau <me@ttaylorr.com>
Date: Nov 8, 2022, 20:28 UTC
Message-ID: <Y2q78ofF8fsAX8XU@nand.local>
In-Reply-To: <pull.1375.git.git.1667934510.gitgitgadget@gmail.com>

On Tue, Nov 08, 2022 at 07:08:26PM +0000, Eric Sunshine via GitGitGadget wrote:

Show 5 quoted lines

> This patch series further improves the output by instead making chainlint.pl
> annotate the original test definition rather than the parsed token stream,
> thus preserving indentation (and whitespace, in general), here-doc bodies,
> etc., which should make it easier for a test author to relate each problem
> back to the source.

Very nicely done. The changes all seemed reasonable to me (and, in fact, the approach is pretty straightforward -- the diffstat is misleading since many of changes are to chainlint's expected output).

So I'm happy with it, but let's hear from some other folks who are more familiar with this area before we start merging it down.

Thanks, Taylor