Re: [PATCH 0/4] chainlint: improve annotated output

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Nov 8, 2022, 22:52 UTC
Message-ID: <CAPig+cTLoyyzU3+qo8UA7iGCh9o9UbowOz_Z_debN3NXoN8=_w@mail.gmail.com>
In-Reply-To: <CAPig+cSWXYhp95kcRn1EHrPW15o_z7uL+TcHO-hf6owP5FQnNw@mail.gmail.com>

On Tue, Nov 8, 2022 at 5:43 PM Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 16 quoted lines

> On Tue, Nov 8, 2022 at 5:29 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
> > On Tue, Nov 08 2022, Eric Sunshine via GitGitGadget wrote:
> > > (Note to self: Add Ævar to nerd-snipe blacklist alongside Peff.)
> >
> > Also, and I guess this is an attempt to evade your blacklist. I *did*
> > notice when playing around with this that if I now expand the "1 while"
> > loop here:
> >    [...]
> > To something that "follows along" with the parser it shouldn't be too
> > hard in the future to add line number annotations now. E.g. for
> > "#!/bin/sh\n" you'll emit a token like "\n", but the positions will be
> > 0, 10.
> >
> > But that's all for some hypothetical future, this is already much better
>
> My nerd-snipe blacklist hasn't fully solidified yet, unfortunately (for me).

I forgot to add that if you do manage to penetrate my nerd-snipe blacklist, such a feature would be built atop the current series (i.e. no reason to hold up this series for the "hypothetical future", as you say).