Re: Git Bug Report: out of memory using git tag

From: Jeff King <peff@peff.net>
Date: Nov 3, 2022, 04:32 UTC
Message-ID: <Y2NEeWwnfHnIbNl8@coredump.intra.peff.net>
In-Reply-To: <49e1eec2-0567-f75e-7d0d-0f2d00ac472c@gmail.com>

On Wed, Nov 02, 2022 at 08:13:27AM -0400, Philippe Blain wrote:

Show 12 quoted lines

> >   [1/2]: ref-filter: fix parsing of signatures without blank lines
> >   [2/2]: ref-filter: fix parsing of signatures with CRLF and no body
> [...]
> One thing I think that is not mentioned in your commit messages is that 1/2
> would also apply to a CRLF-using tag with no blank lines, i.e.
> 
>   this is the subject^M
>   -----BEGIN PGP SIGNATURE-----^M
>   ...some stuff...^M
>   -----END PGP SIGNATURE-----^M
> 
> Parsing this tag correctly is fixed by 1/2, right?

Right. Because there's no blank line to find, neither the "\n\n" nor the "\r\n\r\n" strstr matches, so it is essentially the same case. The fact that the other non-blank lines are CRLF doesn't matter for this part of the code. :)

> Anyway thanks again for the fixes,

No problem!

-Peff