Re: Git Bug Report: out of memory using git tag

From: Philippe Blain <levraiphilippeblain@gmail.com>
Date: Nov 2, 2022, 12:13 UTC
Message-ID: <49e1eec2-0567-f75e-7d0d-0f2d00ac472c@gmail.com>
In-Reply-To: <Y2IeqOT5Ao1Qa0Zl@coredump.intra.peff.net>

Hi Peff,

Le 2022-11-02 à 03:39, Jeff King a écrit :

Show 10 quoted lines

> 
> After sleeping on it, I think I fully understand what's going on. There
> are actually _two_ bugs, but they are closely related. ;)
> 
> Here are patches which fix them both. I may be setting a new record for
> the ratio of commit message lines to changed code. But it took me a
> while to figure out what was going on, so I wanted to explain it fully.
> 
>   [1/2]: ref-filter: fix parsing of signatures without blank lines
>   [2/2]: ref-filter: fix parsing of signatures with CRLF and no body

I read both patches and I concur with Eric, very well explained. I'm sorry for letting that split through at the time; thanks a lot for the fixes. I'm sure it took you less time that it would have taken me!

The new code is even clearer with this additional 'else if' removed.

One thing I think that is not mentioned in your commit messages is that 1/2 would also apply to a CRLF-using tag with no blank lines, i.e.

  this is the subject^M
  -----BEGIN PGP SIGNATURE-----^M
  ...some stuff...^M
  -----END PGP SIGNATURE-----^M

Parsing this tag correctly is fixed by 1/2, right?

Anyway thanks again for the fixes,

Philippe.