Re: ab/misc-hook-submodule-run-command (was: What's cooking in git.git (Oct 2022, #09; Mon, 31))

From: Taylor Blau <me@ttaylorr.com>
Date: Nov 1, 2022, 00:15 UTC
Message-ID: <Y2BlK5uhCy77Ot4Z@nand.local>
In-Reply-To: <221101.86iljz5z7l.gmgdl@evledraar.gmail.com>

On Tue, Nov 01, 2022 at 12:46:57AM +0100, Ævar Arnfjörð Bjarmason wrote:

Show 18 quoted lines

>
> On Mon, Oct 31 2022, Taylor Blau wrote:
>
> > * ab/misc-hook-submodule-run-command (2022-10-31) 3 commits
> >  - run-command tests: test stdout of run_command_parallel()
> >  - submodule tests: reset "trace.out" between "grep" invocations
> >  - hook tests: fix redirection logic error in 96e7225b310
> >
> >  Various test updates.
> >
> >  Waiting for review.
> >  source: <cover-0.3-00000000000-20221029T025520Z-avarab@gmail.com>
>
> I think per
> https://lore.kernel.org/git/221031.86tu3k6u2d.gmgdl@evledraar.gmail.com/
> &
> https://lore.kernel.org/git/221031.86pme86tcg.gmgdl@evledraar.gmail.com/
> that this is ready to advance.

Yeah, I agree. I was mistaken that GIT_TRACE truncated its output when redirected to a file, but it appends. So, the series looks fine to me.

I would still like to hear from Emily, but otherwise I don't have a problem starting to merge this down.

Thanks, Taylor