Re: ab/misc-hook-submodule-run-command (was: What's cooking in git.git (Oct 2022, #09; Mon, 31))

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Nov 2, 2022, 17:13 UTC
Message-ID: <221102.86h6zh2rxf.gmgdl@evledraar.gmail.com>
In-Reply-To: <Y2BlK5uhCy77Ot4Z@nand.local>

On Mon, Oct 31 2022, Taylor Blau wrote:

Show 25 quoted lines

> On Tue, Nov 01, 2022 at 12:46:57AM +0100, Ævar Arnfjörð Bjarmason wrote:
>>
>> On Mon, Oct 31 2022, Taylor Blau wrote:
>>
>> > * ab/misc-hook-submodule-run-command (2022-10-31) 3 commits
>> >  - run-command tests: test stdout of run_command_parallel()
>> >  - submodule tests: reset "trace.out" between "grep" invocations
>> >  - hook tests: fix redirection logic error in 96e7225b310
>> >
>> >  Various test updates.
>> >
>> >  Waiting for review.
>> >  source: <cover-0.3-00000000000-20221029T025520Z-avarab@gmail.com>
>>
>> I think per
>> https://lore.kernel.org/git/221031.86tu3k6u2d.gmgdl@evledraar.gmail.com/
>> &
>> https://lore.kernel.org/git/221031.86pme86tcg.gmgdl@evledraar.gmail.com/
>> that this is ready to advance.
>
> Yeah, I agree. I was mistaken that GIT_TRACE truncated its output when
> redirected to a file, but it appends. So, the series looks fine to me.
>
> I would still like to hear from Emily, but otherwise I don't have a
> problem starting to merge this down.

(Just looking at what I can & can't unblock)

In case that's a "let's hear from the author" (understandable) then this is entirely my work, even if it's her in the "author" header.

Her last version of tha commit was[1], but this entire test is from my[2] re-roll of that topic[3].

1. https://lore.kernel.org/git/20210527000856.695702-8-emilyshaffer@google.com/
2. https://lore.kernel.org/git/patch-03.31-1ad4e69f7da-20210528T110515Z-avarab@gmail.com/
3. https://lore.kernel.org/git/cover-00.31-00000000000-20210528T110515Z-avarab@gmail.com/