Re: [PATCH 1/2] fsck: remove the unused BAD_TAG_OBJECT

From: Jeff King <peff@peff.net>
Date: Oct 24, 2022, 23:39 UTC
Message-ID: <Y1ciT5zuFiZgavIN@coredump.intra.peff.net>
In-Reply-To: <4FFF6EB5-B9A3-4E32-840C-3FD6E893F5BF@gmail.com>

On Mon, Oct 24, 2022 at 02:33:39PM -0400, John Cai wrote:

Show 15 quoted lines

> >>> From: John Cai <johncai86@gmail.com>
> >>>
> >>> The BAD_TAG_OBJECT msg-id is not being used anymore, so we can remove
> >>> it.
> >>
> >> Do you have a ready reference to the change that made it no longer
> >> needed (or stopped detecting the error the message was meant to be
> >> issued against)?
> >
> > 2175a0c6 (fsck: stop checking tag->tagged, 2019-10-18) stopped
> > checking the tagged object referred to by a tag object, which the
> > error message BAD_TAG_OBJECT was about.  Since then the
> > BAD_TAG_OBJECT message is no longer used.
> 
> Thanks for doing my work for me :)

Thanks for finding this. That commit is mine, and I should have removed it then. :)

For future reference, I did the same search via:

  git log -SBAD_TAG_OBJECT fsck.c

I find "-S" is great for these kind of "when did this stop getting used" queries.

-Peff