Re: [PATCH 1/2] fsck: remove the unused BAD_TAG_OBJECT

From: John Cai <johncai86@gmail.com>
Date: Oct 24, 2022, 18:33 UTC
Message-ID: <4FFF6EB5-B9A3-4E32-840C-3FD6E893F5BF@gmail.com>
In-Reply-To: <xmqq4jvtt7cd.fsf@gitster.g>

Hi Junio,

On 24 Oct 2022, at 14:16, Junio C Hamano wrote:

Show 17 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>
>> "John Cai via GitGitGadget" <gitgitgadget@gmail.com> writes:
>>
>>> From: John Cai <johncai86@gmail.com>
>>>
>>> The BAD_TAG_OBJECT msg-id is not being used anymore, so we can remove
>>> it.
>>
>> Do you have a ready reference to the change that made it no longer
>> needed (or stopped detecting the error the message was meant to be
>> issued against)?
>
> 2175a0c6 (fsck: stop checking tag->tagged, 2019-10-18) stopped
> checking the tagged object referred to by a tag object, which the
> error message BAD_TAG_OBJECT was about.  Since then the
> BAD_TAG_OBJECT message is no longer used.

Thanks for doing my work for me :)