Re: [PATCH] git-compat-util.h: GCC deprecated only takes a message in GCC 4.5+

From: Jeff King <peff@peff.net>
Date: Oct 11, 2022, 00:22 UTC
Message-ID: <Y0S3XDToBqnMr4/m@coredump.intra.peff.net>
In-Reply-To: <221006.86edvkr6cc.gmgdl@evledraar.gmail.com>

On Thu, Oct 06, 2022 at 11:15:16PM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 6 quoted lines

> > But if the definition gets much more complicated, then it's probably
> > worth pulling it out rather than repeating it.
> 
> Yeah, I've dealt with that pain before in other contexts. It would be
> great to have a git-compiler-compat.h with just the various
> __attribute__ stuff split off from git-compat-util.h.

I was going to just have unused.h, since I'd worry that piling too much stuff into it will eventually hit a place where some compat/ code is unhappy. But I'd also be OK to _start_ with the UNUSED definition, but call it git-compiler-compat or something, and then people can migrate things as they choose to test them.

> 	+TEST_BUILTINS_OBJS_NO_UNUSED += test-ctype.o

I'd rather not go that route. I already have an UNUSED-clean code base, and once that is all merged we shouldn't need any of that complexity. In the meantime, yes, people introduce new cases, but I am fixing those as they do (and have been for a few years now).

-Peff