Re: [PATCH] git-compat-util.h: GCC deprecated only takes a message in GCC 4.5+

From: Alejandro R. Sedeño <asedeno@mit.edu>
Date: Oct 3, 2022, 23:45 UTC
Message-ID: <CAOO-Oz2WnodBnw86mi2GZ+jLGoGy_saX=kCpwPdm2xohDO1s_Q@mail.gmail.com>
In-Reply-To: <YzthTugwy+eaIUxr@tapette.crustytoothpaste.net>

I'm targeting an old SunOS 5.10 with a GCC 3.4.3, for reasons that can only be described as self-loathing. :-) The other users of GIT_GNUC_PREREQ are used for 2.8, and 3.1, so I figure distinguishing between 4.5+ and <4.5 should be well supported.

Regardless, there's no reason to break older compilers over something that's this trivial to fix.

-Alejandro

On Mon, Oct 3, 2022 at 6:26 PM brian m. carlson <sandals@crustytoothpaste.net> wrote:

Show 14 quoted lines

>
> On 2022-10-03 at 21:23:18, Aleajndro R Sedeño wrote:
> > From: Alejandro R. Sedeño <asedeno@mit.edu>
> >
> > Signed-off-by: Alejandro R. Sedeño <asedeno@mit.edu>
> > Signed-off-by: Alejandro R Sedeño <asedeno@google.com>
>
> It might be helpful to explain what system you're targeting when you see
> this.  CentOS 7 has GCC 4.8, and I'm not aware of any systems with an
> older compiler receiving publicly available updates still.  We've fairly
> recently only been testing and targeting GCC 4.8 for that reason.
> --
> brian m. carlson (he/him or they/them)
> Toronto, Ontario, CA