Re: [PATCH] t/perf: fix test_export() failure with BSD `sed`

From: Jeff King <peff@peff.net>
Date: Dec 18, 2020, 05:42 UTC
Message-ID: <X9xBRXW7/tXsqLT5@coredump.intra.peff.net>
In-Reply-To: <CAPig+cR+4Wh4Sgk6UhUML4SHqaQsvYmw_77ih+oec2YmqQJCCg@mail.gmail.com>

On Wed, Dec 16, 2020 at 02:29:26PM -0500, Eric Sunshine wrote:

Show 6 quoted lines

> > Oh, does anybody need to clear test_export_ to an empty string (or
> > unset it), by the way?
> 
> Perhaps a test_unexport() might be handy in the distant future, but
> presently there is only a single call to test_export() in the entire
> suite, so it's probably not worth worrying about now.

I actually wonder if we could drop test_export entirely. I assume you mean the call in p0001. It is inside a test_expect_success block, where we don't need to do anything fancier than just "export". It is already running in the main script's environment, just like a normal test. If it were in a test_perf, then we would need to take special care to get it back into the main script.

There are some calls in p0000 like that, but they are really about testing test_export itself.

-Peff