git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t/perf: fix test_export() failure with BSD `sed`

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Dec 21, 2020, 07:23 UTC
Message-ID
<CAPig+cRK1rq6xpAXp0bG-nekJOgv9gTZKZZV3xsTVh7CoZY4sQ@mail.gmail.com>
In-Reply-To
<CAPig+cR+4Wh4Sgk6UhUML4SHqaQsvYmw_77ih+oec2YmqQJCCg@mail.gmail.com>
On Wed, Dec 16, 2020 at 2:29 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 9 quoted lines
> That's almost good enough, but test_export() needs to accumulate the
> to-be-exported variables across multiple calls, so the non-recursive
> definition would likely be:
>
>     test_export () {
>         test_export_="$test_export_ $*"
>     }
>
> which would make a nice cleanup atop this portability-fix patch.
A cleanup patch has been posted[1].
[1]: https://lore.kernel.org/git/20201220212740.44273-1-sunshine@sunshineco.com/
Previous: Jeff KingNext: Eric Sunshine
Message 7 of 8 in “t/perf: fix test_export() failure with BSD `sed`”
  1. t/perf: fix test_export() failure with BSD `sed`Eric Sunshine, Dec 16, 2020
  2. Junio C HamanoDec 16, 2020
  3. Eric SunshineDec 16, 2020
  4. Jeff KingDec 18, 2020
  5. Eric SunshineDec 18, 2020
  6. Jeff KingDec 18, 2020
  7. Eric SunshineDec 21, 2020
  8. 2/1 t/perf: avoid unnecessary test_export() recursionEric Sunshine, Dec 20, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.