git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] upload-pack.c: don't free allowed_filters util pointers

From
Jeff King <peff@peff.net>
Date
Dec 4, 2020, 21:04 UTC
Message-ID
<X8qkRRrWCbDn1MAu@coredump.intra.peff.net>
In-Reply-To
<a3c721054f337eac2b3a038e51693f44b68dd619.1607021483.git.me@ttaylorr.com>
On Thu, Dec 03, 2020 at 01:55:18PM -0500, Taylor Blau wrote:
Show 5 quoted lines
> We never noticed this in the tests because we didn't have an example of
> setting 'uploadPackFilter' configuration variables and then following up
> with a valid fetch. The first new 'git clone' prevents further
> regression here. For good measure on top, add a test which checks the
> same behavior at a tree depth greater than 0.

Very nice. The fix is obviously the right thing, but I like the improvements to the tests here especially.

-Peff
Previous: Taylor BlauNext: Taylor Blau
Message 3 of 4 in “upload-pack.c: fix partial clone allowed filter regression”
  1. 0/2 upload-pack.c: fix partial clone allowed filter regressionTaylor Blau, Dec 3, 2020
  2. 2/2 upload-pack.c: don't free allowed_filters util pointersTaylor Blau, Dec 3, 2020
  3. Jeff KingDec 4, 2020
  4. 1/2 builtin/clone.c: don't ignore transport_fetch_refs() errorsTaylor Blau, Dec 3, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.