From: Jeff King <peff@peff.net>
Date: Fri, 04 Dec 2020 21:04:05 GMT
Subject: Re: [PATCH 2/2] upload-pack.c: don't free allowed_filters util pointers
Message-ID: <X8qkRRrWCbDn1MAu@coredump.intra.peff.net>
In-Reply-To: <a3c721054f337eac2b3a038e51693f44b68dd619.1607021483.git.me@ttaylorr.com>

On Thu, Dec 03, 2020 at 01:55:18PM -0500, Taylor Blau wrote:

> We never noticed this in the tests because we didn't have an example of
> setting 'uploadPackFilter' configuration variables and then following up
> with a valid fetch. The first new 'git clone' prevents further
> regression here. For good measure on top, add a test which checks the
> same behavior at a tree depth greater than 0.

Very nice. The fix is obviously the right thing, but I like the
improvements to the tests here especially.

-Peff