Re: [PATCH v4 0/8] fetch: rework negotiation tip options

> Updates in v4
> =============
> 
> Thanks, Matthew, for the detailed review! There are some big changes in this
> version.
> 
>   * Expanded commit message to cite the commit that introduced the bug
>     (3f763ddf28).
>   * Renamed --negotiation-tip to --negotiation-restrict throughout docs/code
>     (including send-pack.c, transport-helper.c, builtin/pull.c). Added
>     OPT_ALIAS in git-pull.
>   * Switched config parsing to use parse_transport_option() helper. Removed
>     git push from docs (not implemented yet). Restructured --negotiate-only
>     validation flow.
>   * NEW Patch 5: Added have_sent() interface to negotiators, so included
>     haves can be de-duplicated properly by the negotiation algorithm.
>   * Replaced COMMON flag hack with negotiator->have_sent() calls. Moved
>     ref-pattern resolution into builtin/fetch.c (add_negotiation_tips()) so
>     fetch-pack receives pre-resolved oid_array instead of string_list. Added
>     test for --negotiation-tip ignoring missing refs. Added
>     duplicate-avoidance test for v0. Accepts commit hashes in addition to ref
>     names/globs.
>   * Use parse_transport_option() for config. Updated docs to mention commit
>     hashes. Removed git push from config docs. Fixed test to use correct
>     restrict/include combinations.
>   * In the last patch, add doc notes that remote config values also apply
>     during git push with push.negotiate, now that they are integrated by that
>     change.
>