git/list[1] front-page[2] threads[3] people[4] search[5] about
 

RE: Supporting "-v" option for git-log

From
TMTim Mazid <timmazid@hotmail.com>
Date
May 25, 2011, 11:35 UTC
Message-ID
<SNT124-W15FA6D1CACA43B253810FAC4740@phx.gbl>
In-Reply-To
<BANLkTikT4s+Twfip2g7Zo-XcML1Wbd3qBg@mail.gmail.com>
Show 9 quoted lines
> Date: Wed, 25 May 2011 14:28:12 +0300
> From: elazarl@gmail.com
> On Wed, May 25, 2011 at 2:21 PM, Tim Mazid  wrote:
> >
> > Well, personally, I've never used the --grep option. I pipe it through
> > grep, where I can supply options such as -v.
>
> But then you must use single-line commits output. Which is
> inconvenient if you want to read all the commit message.
That is a good point.
Show 12 quoted lines
> > As for the syntax, that seems like a good idea on the surface, but
> > how would you go about supporting other grep options? Such as
> > "-i"?
>
> Now that I think of it, we already have the '--not' option for
> revision specifiers. Why won't we use it for grep patterns? That way
> -v will not be overloaded (it usually means verbose). For example
>
> git log --all --not --grep A --grep B
>
> Would mean find all commits without A and with B, in SQL "SELECT *
> FROM COMMITS WHERE message NOT LIKE '%A%' AND message LIKE '%B%'".

But how do you know which "--grep" the "--not" applies to? Does it have to go directly before the "--grep" option? Can it be a few options before as long is it's still before? If you want to find commits not matching two patterns, do you have to do "--not --grep A --not --grep B"?

I can see this as being a possible source of confusion; people doing "--not grep A --grep B" and expecting it to mean NOT A AND NOT B.

Tim.
() ascii ribbon campaign - against html e-mail
/\ www.asciiribbon.org - against proprietary attachments
Previous: Elazar LeibovichNext: Elazar Leibovich
Message 7 of 14 in “Supporting "-v" option for git-log”
  1. Elazar LeibovichMay 25, 2011
  2. Tim MazidMay 25, 2011
  3. Elazar LeibovichMay 25, 2011
  4. Tim MazidMay 25, 2011
  5. Tim MazidMay 25, 2011
  6. Elazar LeibovichMay 25, 2011
  7. Tim MazidMay 25, 2011
  8. Elazar LeibovichMay 25, 2011
  9. Jeff KingMay 25, 2011
  10. Jakub NarebskiMay 25, 2011
  11. Jeff KingMay 25, 2011
  12. Jakub NarebskiMay 25, 2011
  13. Junio C HamanoMay 25, 2011
  14. Jeff KingMay 25, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.